Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEATURE: add slow_mode_prevents_editing setting.. #13534

Merged
merged 1 commit into from
Jun 28, 2021

Conversation

3-w-c
Copy link

@3-w-c 3-w-c commented Jun 27, 2021

@discoursebot
Copy link

This pull request has been mentioned on Discourse Meta. There might be relevant details there:

https://meta.discourse.org/t/edit-old-posts-in-a-slow-topic/171489/8

@eviltrout
Copy link
Contributor

Did you link to the wrong topic? I don't see anything about edits in that topic. Also, this defaults to true which is questionable.

@mintsaxon
Copy link
Contributor

Yes, sorry, wrong link, the right one is here: https://meta.discourse.org/t/edit-old-posts-in-a-slow-topic/171489/3 (thanks discoursebot!).

Also, this defaults to true which is questionable.

I set the default to true because that matches how Discourse currently works (i.e. edits aren't permitted after editing_grace_period).

I don't really have an opinion about the default, I can see both sides – and the instance we're running will flip it to false as soon as we're able. It seems like a pretty big change for forums to suddenly start allowing slow-mode edits, so maybe if y'all prefer false there's a way of only having that apply to new sites?

@eviltrout
Copy link
Contributor

@mintsaxon thanks for the clarification. It was my mistake and your default sounds good. I'm going to merge it now.

@eviltrout eviltrout merged commit 7d0d13c into discourse:master Jun 28, 2021
@mintsaxon
Copy link
Contributor

Much appreciated, sorry for not being clearer the first time round!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants