FIX: Load the category when the category_id attr is present. #13621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The store won't autoload the reviewable category anymore as we removed that piece of code in #13412. This commit adds it as a computed property.
eviltrout
approved these changes
Jul 2, 2021
|
If #13412 was meant to remove unused code and it was actually used, why not just revert it? |
|
I agree with @danielwaterworth - the revert is probably better |
|
We'll not revert the other commit as the topic also adds the category as a computed property. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The store won't autoload the reviewable category anymore as we removed that piece of code in #13412. This commit adds it as a computed property.