Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DEV: improve header dock class implementation #13840

Closed
wants to merge 5 commits into from
Closed

DEV: improve header dock class implementation #13840

wants to merge 5 commits into from

Conversation

hnb-ku
Copy link
Contributor

@hnb-ku hnb-ku commented Jul 25, 2021

WIP

@jjaffeux
Copy link
Contributor

Didn't try it live, but approach sounds good to me.

@hnb-ku hnb-ku marked this pull request as ready for review July 28, 2021 03:17
jjaffeux
jjaffeux reviewed Aug 13, 2021
View reviewed changes
app/assets/javascripts/discourse/app/components/sticky-header-anchor.js
didInsertElement() {
this._super(...arguments);

if (this.element) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how could element be null here ?

@hnb-ku hnb-ku closed this Sep 21, 2021
@gschlager gschlager deleted the header-dock-fix branch February 24, 2023 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjaffeux jjaffeux jjaffeux left review comments

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hnb-ku @jjaffeux