Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEATURE: add Unseen view #13977

Merged
merged 9 commits into from
Aug 10, 2021
Merged

FEATURE: add Unseen view #13977

merged 9 commits into from
Aug 10, 2021

Conversation

AndrewPrigorshnev
Copy link
Contributor

This view is the same as Latest except it hides the topics you have fully read. Based on this plugin of @davidtaylorhq https://meta.discourse.org/t/simple-unread-list-plugin-discourse-simple-unread/70013.

Copy link
Contributor

@eviltrout eviltrout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a really clean PR, thank you. I made an extremely trivial suggestion to correct the grammar of the minutes method.

spec/components/topic_query_spec.rb Outdated Show resolved Hide resolved
spec/components/topic_query_spec.rb Outdated Show resolved Hide resolved
spec/components/topic_query_spec.rb Outdated Show resolved Hide resolved
lib/topic_query.rb Outdated Show resolved Hide resolved
Co-authored-by: Robin Ward <robin.ward@gmail.com>
@AndrewPrigorshnev AndrewPrigorshnev merged commit 622859d into main Aug 10, 2021
@AndrewPrigorshnev AndrewPrigorshnev deleted the feature/add-unseen-view branch August 10, 2021 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants