FEATURE: Allow users to remove their vote #14459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They can use the remove vote button or select the same option again for single choice polls.
ZogStriP
reviewed
Sep 28, 2021
ZogStriP
reviewed
Sep 28, 2021
ZogStriP
reviewed
Sep 28, 2021
ZogStriP
reviewed
Sep 28, 2021
ZogStriP
reviewed
Sep 28, 2021
nbianca
force-pushed
the
feature_poll_unvote
branch
from
a0fefc4
to
c376eda
Compare
ZogStriP
reviewed
Sep 28, 2021
ZogStriP
approved these changes
Sep 28, 2021
|
This pull request has been mentioned on Discourse Meta. There might be relevant details there: |
tgxworld
reviewed
Sep 29, 2021
tgxworld
reviewed
Sep 29, 2021
ZogStriP
reviewed
Sep 30, 2021
|
|
||
| begin | ||
| poll, options = DiscoursePoll::Poll.vote(post_id, poll_name, options, current_user) | ||
| render json: { poll: poll, vote: options } |
There was a problem hiding this comment.
I am not sure exactly why, but this is the name in JavaScript too. It makes sense because a vote is nothing more than a set of selected poll options.
ZogStriP
reviewed
Sep 30, 2021
ZogStriP
reviewed
Sep 30, 2021
ZogStriP
reviewed
Sep 30, 2021
ZogStriP
approved these changes
Sep 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They can use the remove vote button or select the same option again for
single choice polls.