FEATURE: Add email blocking using regex #14481
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blocked_email_pattern site setting can block email matching a regular expression.
ZogStriP
reviewed
Sep 30, 2021
| elsif (setting = SiteSetting.blocked_email_domains).present? | ||
| return !(email_in_restriction_setting?(setting, email) && !is_developer?(email)) | ||
| elsif SiteSetting.blocked_email_domains.present? || SiteSetting.blocked_email_pattern.present? | ||
| return !(email_in_restriction_setting?(SiteSetting.blocked_email_domains, email) || |
There was a problem hiding this comment.
Do we need these two methods? Or would just one be enough?
There was a problem hiding this comment.
One accepts a regular expression and the other one accepts a list of domains and converts it to a regular expression. I'd say yes, because the alternative is to convert it to regular expression before calling the method.
ZogStriP
approved these changes
Oct 8, 2021
|
There is another better implementation for the same problem #14593. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
blocked_email_pattern site setting can block email matching a regular
expression.