FIX: Topic timeline not updating in megatopics. #14645
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this fix, jumping to posts using the topic timeline scrollbar will not update the counts since the topic scrollarea is not rerendered. Follow-up to db337b1
tgxworld
force-pushed
the
fix_topic_timeline_on_mega_topics
branch
from
e5a42ec
to
0eab101
Compare
tgxworld
commented
Oct 19, 2021
| @@ -555,7 +555,7 @@ export default createWidget("topic-timeline", { | |||
| if (!attrs.mobileView) { | |||
| const streamLength = attrs.topic.get("postStream.stream.length"); | |||
|
|
|||
| if (streamLength < 2) { | |||
| if (streamLength === 1) { | |||
There was a problem hiding this comment.
Megatopics do not have a stream so the streamLength will always be zero.
davidtaylorhq
approved these changes
Oct 19, 2021
|
Thank you @davidtaylorhq |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this fix, jumping to posts using the topic timeline scrollbar
will not update the counts since the topic scrollarea is not rerendered.
Follow-up to db337b1