Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UPDATE: add latest update section & Cloudflare instruction #14719

Closed
wants to merge 3 commits into from
Closed

UPDATE: add latest update section & Cloudflare instruction #14719

wants to merge 3 commits into from

Conversation

Gavin-X
Copy link
Contributor

@Gavin-X Gavin-X commented Oct 26, 2021

install-cloud.md file update

@discoursebot
Copy link

This pull request has been mentioned on Discourse Meta. There might be relevant details there:

https://meta.discourse.org/t/missing-a-vital-step-in-the-official-install-guide/207106/5

@ldmosquera ldmosquera changed the title UPDATE: add latest update section & cloudfare instruction UPDATE: add latest update section & Cloudflare instruction Oct 27, 2021
ldmosquera
ldmosquera suggested changes Oct 27, 2021
View reviewed changes
Copy link
Contributor

@ldmosquera ldmosquera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small typo

docs/INSTALL-cloud.md Outdated Show resolved Hide resolved
@ldmosquera ldmosquera removed the request for review from rishabhnambiar October 27, 2021 13:44
@xfalcox
Copy link
Member

xfalcox commented Oct 27, 2021

Updates are already covered by

discourse/docs/INSTALL-cloud.md

Line 119 in 1c7833b

- We strongly suggest you turn on automatic security updates for your OS. In Ubuntu use the `dpkg-reconfigure -plow unattended-upgrades` command. In CentOS/RHEL, use the [`yum-cron`](https://www.redhat.com/sysadmin/using-yum-cron) package.

@Gavin-X
Copy link
Contributor Author

Gavin-X commented Oct 27, 2021

Updates are already covered by

discourse/docs/INSTALL-cloud.md

Line 119 in 1c7833b

- We strongly suggest you turn on automatic security updates for your OS. In Ubuntu use the `dpkg-reconfigure -plow unattended-upgrades` command. In CentOS/RHEL, use the [`yum-cron`](https://www.redhat.com/sysadmin/using-yum-cron) package.

The security updates are only covered after the install. There are some dependency that needs to be updated before discourse install.

This person was having an issue installing discourse until he upgraded.

https://meta.discourse.org/t/problem-with-self-hosted-instance/207088

@rishabhnambiar
Copy link
Member

I don't think we should do a full section on this because the guide is already pretty long. @xfalcox what do you think about folding a sentence into the previous section instead?

image

Your call, we could also leave it as it is for now but I think reminding people to update their packages is a good idea anyway.

@Gavin-X
Copy link
Contributor Author

Gavin-X commented Oct 29, 2021

I don't think we should do a full section on this because the guide is already pretty long. @xfalcox what do you think about folding a sentence into the previous section instead?

image

Your call, we could also leave it as it is for now but I think reminding people to update their packages is a good idea anyway.

Can you give me the text so that I can update my PR please

@SamSaffron
Copy link
Member

Sorry but I am closing this, let's discuss this documentation change on meta.

@SamSaffron SamSaffron closed this Jan 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ldmosquera ldmosquera ldmosquera requested changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Gavin-X @discoursebot @xfalcox @rishabhnambiar @SamSaffron @ldmosquera