DEV: Make it clear that plugin-api on the client side follows semver. #15070
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgxworld
commented
Nov 24, 2021
| @@ -93,7 +93,8 @@ import { | |||
| import { CUSTOM_USER_SEARCH_OPTIONS } from "select-kit/components/user-chooser"; | |||
| import { downloadCalendar } from "discourse/lib/download-calendar"; | |||
|
|
|||
| // If you add any methods to the API ensure you bump up this number | |||
| // If you add any methods to the API ensure you bump up the version number | |||
| // based on Semantic Versioning 2.0.0. | |||
There was a problem hiding this comment.
I think we should be more explicit about this. I've often seen the patch version being bumped when we're adding new features in a backwards compatible manner.
tgxworld
changed the title
tgxworld
force-pushed
the
clarify_versioning_for_plugin_api
branch
from
fab85b8
to
d7dd4c4
Compare
CvX
approved these changes
Nov 24, 2021
tgxworld
force-pushed
the
clarify_versioning_for_plugin_api
branch
from
d7dd4c4
to
c90d33e
Compare
|
@eviltrout @CvX Thank you for reviewing 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.