UX: clear action snapshots when composer popup is canceled. #15846
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, composer kept last visited topic in action snapshots even after the composer popup is cancelled by the user.
|
This pull request has been mentioned on Discourse Meta. There might be relevant details there: https://meta.discourse.org/t/composer-keeps-the-last-visited-topic-composer-reply-action/216839/4 |
eviltrout
approved these changes
Feb 7, 2022
|
@vinothkannans Do we still need this PR or are we good to merge? |
|
@tgxworld it's in a tricky state. This PR raised another concern while fixing the original problem. I'm unable to fix it in a clean way. So I put it on hold. I will try again this or next week. |
|
I will reopen a new PR with a different approach. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the composer kept the last visited topic in action snapshots even after the composer popup is canceled by the user.