Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEV: Update highlight.js to version 11 #18282

Merged
merged 1 commit into from
Sep 20, 2022
Merged

DEV: Update highlight.js to version 11 #18282

merged 1 commit into from
Sep 20, 2022

Conversation

xfalcox
Copy link
Member

@xfalcox xfalcox commented Sep 20, 2022

No description provided.

Copy link
Contributor

@pmusaraj pmusaraj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool!

Do you know what would happen if someone tries to use a language defined for the previous highlightJS version? There are some examples here: https://meta.discourse.org/t/hack-to-install-a-new-language-for-highlight-js-on-a-hosted-discourse/55818/15

I would be happy if older definitions failed silently, we can then just let consumers know that they need updates to 11 for custom language definitions.

There's also this: https://github.com/discourse/hljs-theme-picker, would be good to check whether it works with 11.

@xfalcox
Copy link
Member Author

xfalcox commented Sep 20, 2022

Do you know what would happen if someone tries to use a language defined for the previous highlightJS version? There are some examples here: https://meta.discourse.org/t/hack-to-install-a-new-language-for-highlight-js-on-a-hosted-discourse/55818/15

They work just fine per my test with https://github.com/Jai-Community/discourse-highlightjs-jai

There's also this: https://github.com/discourse/hljs-theme-picker, would be good to check whether it works with 11.

Got a PR up to update it's definitions at discourse/hljs-theme-picker#3

However, per Meta reports, that component is broken for a while.

@xfalcox xfalcox merged commit 685e0da into main Sep 20, 2022
@xfalcox xfalcox deleted the highlightjs-11 branch September 20, 2022 15:43
@discoursebot
Copy link

This pull request has been mentioned on Discourse Meta. There might be relevant details there:

https://meta.discourse.org/t/codeblock-theme-picker/146396/24

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants