FIX: Do not preview chat channels to read-only users #21700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM, let's merge it tomorrow after our call 👍 Thanks |
jjaffeux
approved these changes
May 23, 2023
|
This pull request has been mentioned on Discourse Meta. There might be relevant details there: https://meta.discourse.org/t/introducing-default-chat-channels-automatically-add-users/233141/40 |
enduvar
pushed a commit
to ForgottenWorld/discourse
that referenced
this pull request
Sep 8, 2023
We want to simplify this case as it contains a lot of rabbit holes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were some rough edges with allowing read-only users to preview channels that we aren't sure how we want to address, so we've decided to remove that feature for the time being.