Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Badge system updates #2271

Merged
merged 9 commits into from
Apr 17, 2014
Merged

Badge system updates #2271

merged 9 commits into from
Apr 17, 2014

Conversation

vikhyat
Copy link
Contributor

@vikhyat vikhyat commented Apr 16, 2014

Implements (mostly) priorities #1-#5 listed here: https://meta.discourse.org/t/badges-feedback/13789/13

Pending:

  1. Redirecting /badges/:id/wrong-slug to the correct URL.
  2. Pagination/infinite scroll of users on the badge page instead of showing the 20 most recent grants? Or alternately just display all users who were granted the badge?

@vikhyat vikhyat changed the title Badge system Badge system updates Apr 16, 2014
@discoursebot
Copy link

You've signed the CLA, vikhyat. Thank you! This pull request is ready for review.

@vikhyat
Copy link
Contributor Author

vikhyat commented Apr 16, 2014

#6 and #8 are also complete now.

@vikhyat
Copy link
Contributor Author

vikhyat commented Apr 16, 2014

Some UI screenshots:


screen shot 2014-04-17 at 1 43 25 am


screen shot 2014-04-17 at 1 43 08 am


screen shot 2014-04-17 at 1 42 49 am


screen shot 2014-04-17 at 1 44 07 am

@ZogStriP
Copy link
Member

❤️ ❤️ ❤️ ❤️ ❤️ ❤️ ❤️ ❤️ ❤️ ❤️ ❤️ ❤️ ❤️ ❤️ ❤️ ❤️ ❤️ ❤️ ❤️ ❤️ ❤️ ❤️ ❤️ ❤️ ❤️ ❤️ ❤️ ❤️

@SamSaffron
Copy link
Member

Thanks heaps ... more priorities in the oven 👍

SamSaffron added a commit that referenced this pull request Apr 17, 2014
@SamSaffron SamSaffron merged commit 87f37b3 into discourse:master Apr 17, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants