Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Admin User-IP locator #2446

Merged
merged 1 commit into from
Jun 18, 2014
Merged

Conversation

gnunicorn
Copy link
Contributor

Implements the step 1-3 of the Admin User-IP-Locator spec as discussed here:

screen shot 2014-06-15 at 18 59 20


screen shot 2014-06-15 at 18 58 27

Details:

  • when an IP given, with a click on the new "lookup" button the Admin can trigger an IP-Reverse look up
  • uses ipinfo.io directly through jsonp (avoids round-trips)
  • shows hostname, location and all known details (if found)
  • automatically links long-lat to a google-maps link opening in a new window/tab
  • looks up other users also using that IP and shows them under

Notes:

  • misses copy-edit/translations (and therefore will probably fail the travis build)
  • the "No Hostname" I receive back from ipinfo as a value

@discoursebot
Copy link

You've signed the CLA, ligthyear. Thank you! This pull request is ready for review.

@coding-horror
Copy link
Contributor

Looks amazing will be a huge help!

@SamSaffron
Copy link
Member

Looks good to me, but please let's include English strings, @coding-horror can improve copy later on.

@coding-horror
Copy link
Contributor

You can just include hello world strings, happy to edit right after merge

@gnunicorn
Copy link
Contributor Author

@coding-horror , @SamSaffron . Added string stubs. Rebased for prettier history.

screen shot 2014-06-16 at 09 08 30

@SamSaffron
Copy link
Member

@ligthyear not merging cleanly anymore, can you fix

@coding-horror
Copy link
Contributor

@ligthyear can you give this some adjustment? Then we can merge and I can contribute copy. Anxious to see this shipping!

@gnunicorn
Copy link
Contributor Author

rebased. Applies cleanly again. Ready to be shipped.

SamSaffron added a commit that referenced this pull request Jun 18, 2014
@SamSaffron SamSaffron merged commit 82ff283 into discourse:master Jun 18, 2014
@SamSaffron
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

6 participants