-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use English as fallback for missing strings when generating translation ... #2635
Use English as fallback for missing strings when generating translation ... #2635
Conversation
You've signed the CLA, nichtsistwahr. Thank you! This pull request is ready for review. |
My worry here is that we are putting something into "dev" environment for production. I would much prefer if
|
…on js; making it actually work -.-
I can see that. Since I am not that experienced with rails development, I could use some pointers. I guess I would have to:
Am I missing something? |
Sam isn't this obviated by your changes documented here: and
Use:
? |
@coding-horror this is related but not the same issue, the attempt here is to make the UI usable in production in cases where only partial translation is available (fallback to English) |
@eviltrout we need to think about a solution here, we want to enable fallback localization in EN but only in prd. |
Can't we just do it when baking the assets though? In production mode, mix in the english keys? |
yeah that was what I was thinking. On Tue, Nov 25, 2014 at 2:18 AM, Robin Ward notifications@github.com
|
Closing this for now as it is getting pretty old. Let's revisit later. |
Generate client translation js with English fallback as suggested in https://meta.discourse.org/t/missing-translation-defaults-to-english/15771/9