added observer to Discourse.PagedownEditor value to refresh previewer

[awbergs]

Added an observer to the Discourse.PagedownEditor class so that any changes to the value refresh the Markdown preview.

[discoursebot]

You've signed the CLA, awbergs. Thank you! This pull request is ready for review.

[awbergs]

This is in response to issue #357.

[SamSaffron]

I see what you did there, but how does this avoid double updates, is there something that need unwiring?

[awbergs]

At the very most this behaves the same as the composer view. The Markdown.Editor wiring that handles calling refresh is actually commented out (and has been since the initial commit). We could presumably remove that code now and just use the Discourse.PagedownEditor control now.

There is also a debouncer in front of the preview generation. The only place where I could see there possibly being a double update is if any keyboard undo action is performed. The undo control that is initialized inside of Markdown.Editor calls refresh on undo/redo.

[SamSaffron]

Sounds good to me!

On Monday, 11 March 2013 at 3:47 PM, Austin Bergstrom wrote:

At the very most this behaves the same as the composer view. The Markdown.Editor wiring that handles calling refresh is actually commented out (https://github.com/discourse/discourse/blob/master/app/assets/javascripts/external/Markdown.Editor.js#L1069) (and has been since the initial commit). We could presumably remove that code now and just use the Discourse.PagedownEditor control now.
There is also a debouncer in front of the preview generation. The only place where I could see there possibly being a double update is if any keyboard undo action is performed. The undo control that is initialized inside of Markdown.Editor (https://github.com/discourse/discourse/blob/master/app/assets/javascripts/external/Markdown.Editor.js#L149) calls refresh on undo/redo.

—
Reply to this email directly or view it on GitHub (#414 (comment)).

[eviltrout]

Thanks this looks good 🐟