FEATURE: Allow disabling link tracking with .no-track-link class #4160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You've signed the CLA, NuckChorris. Thank you! This pull request is ready for review. |
NuckChorris
force-pushed
the
no-track-link
branch
from
ebbf24a
to
43f0198
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was running into some trouble with link tracking breaking a signup CTA link I'd insert into a onebox at runtime, because the
.onebox-resultsancestor doesn't trigger a return until much later — after the link has been rewritten. This allows disabling link tracking on any link just by adding ano-track-linkclass. The name is kinda weird but I wanted to match the existingtrack-linkclass which enables link tracking on otherwise-disabled links.