Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to rails 5 1 #5122

Merged
merged 10 commits into from
Sep 25, 2017
Merged

Upgrade to rails 5 1 #5122

merged 10 commits into from
Sep 25, 2017

Conversation

tgxworld
Copy link
Contributor

@tgxworld tgxworld commented Aug 31, 2017 •
edited
Loading

25 September 2017

RAILS_ENV=profile ruby script/bench.rb -n -u -i 2000

Master branch

categories:
  50: 47
  75: 52
  90: 60
  99: 81
home:
  50: 51
  75: 56
  90: 63
  99: 94
topic:
  50: 62
  75: 67
  90: 76
  99: 109
categories_admin:
  50: 76
  75: 81
  90: 88
  99: 129
home_admin:
  50: 79
  75: 85
  90: 106
  99: 130
topic_admin:
  50: 97
  75: 103
  90: 116
  99: 163
timings:
  load_rails: 1176
ruby-version: 2.4.2-p198
rss_kb: 198176
pss_kb: 141419
virtual: physical
architecture: amd64
operatingsystem: Ubuntu
memorysize: 15.59 GB
kernelversion: 4.10.0
physicalprocessorcount: 1
processor0: Intel(R) Core(TM) i7-6700K CPU @ 4.00GHz
rss_kb_12442: 323088
pss_kb_12442: 261759
rss_kb_12519: 322852
pss_kb_12519: 261391
rss_kb_12728: 323920
pss_kb_12728: 262283

Rails 5.1.3 before patch

categories:
  50: 46
  75: 49
  90: 53
  99: 81
home:
  50: 49
  75: 53
  90: 56
  99: 75
topic:
  50: 64
  75: 68
  90: 72
  99: 90
categories_admin:
  50: 76
  75: 80
  90: 85
  99: 99
home_admin:
  50: 78
  75: 82
  90: 87
  99: 117
topic_admin:
  50: 99
  75: 105
  90: 111
  99: 138
timings:
  load_rails: 1181
ruby-version: 2.4.2-p198
rss_kb: 220864
pss_kb: 158038
virtual: physical
architecture: amd64
operatingsystem: Ubuntu
memorysize: 15.59 GB
kernelversion: 4.10.0
physicalprocessorcount: 1
processor0: Intel(R) Core(TM) i7-6700K CPU @ 4.00GHz
rss_kb_15625: 354920
pss_kb_15625: 287611
rss_kb_15696: 356432
pss_kb_15696: 288974
rss_kb_15914: 355960
pss_kb_15914: 288242

Rails 5.1.3 after patch

categories:
  50: 45
  75: 48
  90: 52
  99: 79
home:
  50: 48
  75: 52
  90: 56
  99: 73
topic:
  50: 63
  75: 69
  90: 74
  99: 91
categories_admin:
  50: 76
  75: 81
  90: 87
  99: 99
home_admin:
  50: 78
  75: 82
  90: 88
  99: 119
topic_admin:
  50: 96
  75: 102
  90: 107
  99: 138
timings:
  load_rails: 1201
ruby-version: 2.4.2-p198
rss_kb: 218996
pss_kb: 154438
virtual: physical
architecture: amd64
operatingsystem: Ubuntu
memorysize: 15.59 GB
kernelversion: 4.10.0
physicalprocessorcount: 1
processor0: Intel(R) Core(TM) i7-6700K CPU @ 4.00GHz
rss_kb_18213: 353252
pss_kb_18213: 284426
rss_kb_18289: 354248
pss_kb_18289: 284927
rss_kb_18512: 353264
pss_kb_18512: 283948

@discoursebot
Copy link

You've signed the CLA, tgxworld. Thank you! This pull request is ready for review.

@tgxworld tgxworld force-pushed the upgrade_to_rails_5_1 branch 4 times, most recently from 31e7b1e to 5ec328d Compare August 31, 2017 09:07
@discoursebot
Copy link

This pull request has been mentioned on Discourse Meta. There might be relevant details there:

https://meta.discourse.org/t/when-should-discourse-upgrade-to-rails-5/67123/8

This was referenced Sep 1, 2017
Merged
Merged
@discourse discourse deleted a comment from Thereenewhe Sep 2, 2017
This was referenced Sep 2, 2017
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@tgxworld tgxworld closed this Sep 4, 2017
@tgxworld tgxworld reopened this Sep 4, 2017
@discoursebot
Copy link

You've signed the CLA, tgxworld. Thank you! This pull request is ready for review.

@tgxworld tgxworld force-pushed the upgrade_to_rails_5_1 branch 4 times, most recently from 7851917 to c487480 Compare September 5, 2017 01:42
@tgxworld tgxworld force-pushed the upgrade_to_rails_5_1 branch 6 times, most recently from 176e3d0 to 587cdf6 Compare September 13, 2017 08:48
@tgxworld tgxworld force-pushed the upgrade_to_rails_5_1 branch 8 times, most recently from 2a73d3a to 19705be Compare September 20, 2017 05:08
@tgxworld tgxworld closed this Sep 25, 2017
@tgxworld tgxworld reopened this Sep 25, 2017
@discoursebot
Copy link

You've signed the CLA, tgxworld. Thank you! This pull request is ready for review.

@tgxworld tgxworld force-pushed the upgrade_to_rails_5_1 branch 5 times, most recently from 9cf731b to 4dbec2e Compare September 25, 2017 05:27
@tgxworld tgxworld merged commit cf9607a into discourse:master Sep 25, 2017
@tgxworld tgxworld deleted the upgrade_to_rails_5_1 branch September 25, 2017 05:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tgxworld @discoursebot