FIX: allow multiple secondary emails #5452
Conversation
|
You've signed the CLA, LeoMcA. Thank you! This pull request is ready for review. |
|
LGTM 👍 but I'll leave it to @tgxworld to merge it. |
|
looks good but lets wait one more week to merge till 1.9 is out |
|
This pull request has been mentioned on Discourse Meta. There might be relevant details there: https://meta.discourse.org/t/additional-email-support/59847/13 |
|
@SamSaffron 1.9's been out a while now, is this ready to merge? |
LeoMcA
force-pushed
the
multiple-alternate-emails
branch
from
6217dde
to
ebf3de0
Compare
No worries!
Done 🎉 |
|
@LeoMcA Just to provide you with an update, this is actually on my plate but we're seeing an issue where users can be created without an email. The bad news is that I've not been able to reproduce it yet so we're still adding more logging to see if we can figure it out. This PR will be placed on hold still we fix that bug. |
|
@gschlager thought I'd remind you 79590e4 can be reverted now |
While working on adding multiple email support to the email receiver (which, based on the tests I've been writing, seems to already exist... but that's a story for another PR) I was running into errors adding multiple secondary email addresses to a user.
This fixes up the validator, and replaces the index with a partial index, to allow that to happen.