FIX: Don't count the current user in "Others with this badge." #6016
Conversation
|
You've signed the CLA, misaka4e21. Thank you! This pull request is ready for review. |
| @@ -25,7 +25,7 @@ export default Ember.Controller.extend(BadgeSelectController, { | |||
|
|
|||
| @computed("username", "model.grant_count", "userBadges.grant_count") | |||
| grantCount(username, modelCount, userCount) { | |||
| return username ? userCount : modelCount; | |||
| return username ? userCount : modelCount - 1; | |||
There was a problem hiding this comment.
hmm how do we know if the user hass been granted that badge or not?
There was a problem hiding this comment.
I added a new computed variable othersCount to exclude the current user. It will be shown only if canShowOthers is true.
misaka4e21
force-pushed
the
fix-badge-others
branch
from
5207c40
to
0758a33
Compare
| @@ -28,6 +28,11 @@ export default Ember.Controller.extend(BadgeSelectController, { | |||
| return username ? userCount : modelCount; | |||
| }, | |||
|
|
|||
| @computed("model.grant_count") | |||
| othersCount(grant_count) { | |||
| return grant_count - 1; | |||
There was a problem hiding this comment.
Oh, this is not going to be a simple -1, you could have multiple badges of the type, so you need to subtract the number you have.
There was a problem hiding this comment.
Changed.
Should I consider that other people can also have multiple badges per person?
Don't count the current user in "Others with this badge".
misaka4e21
force-pushed
the
fix-badge-others
branch
from
b176eb6
to
087a458
Compare
|
This pull request has been mentioned on Discourse Meta. There might be relevant details there: https://meta.discourse.org/t/count-at-others-with-this-badge-includes-current-user/90089/4 |
https://meta.discourse.org/t/count-at-others-with-this-badge-includes-current-user/90089