FEATURE: New post editing period for >= tl2 users #8070
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
rimian
commented
Sep 4, 2019
rimian
commented
- Adds a new setting and for tl2 editing posts (30 days same as old value)
- Sets the tl0/tl1 editing period as 1 day
* Adds a new setting and for tl2 editing posts (30 days same as old value) * Sets the tl0/tl1 editing period as 1 day
|
You've signed the CLA, rimian. Thank you! This pull request is ready for review. |
* Fix site setting on guardian spec
|
Is there a relevant meta discussion for this change? I'm looking for some context here. |
|
Sorry, I am not sure where to reference things and where to put the context just yet. I'll clear that up before my next PR :) |
|
Yeah a quick link in the PR is always a good idea cause there are many of us, but really not a huge deal. |
SamSaffron
reviewed
Sep 5, 2019
SamSaffron
reviewed
Sep 5, 2019
|
Overall the change looks good to me! minor changes to the specs and we should be good to merge. |
* Avoid shared examples * Use update_columns to avoid callbacks on user during tests
|
This pull request has been mentioned on Discourse Meta. There might be relevant details there: https://meta.discourse.org/t/spam-bots-tricking-discourse-filter-by-editing/101684/23 |
eviltrout
approved these changes
Sep 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.