Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DEV: adds discourse:focus-changed app event #8123

Merged
merged 1 commit into from
Oct 2, 2019
Merged

DEV: adds discourse:focus-changed app event #8123

merged 1 commit into from
Oct 2, 2019

Conversation

jjaffeux
Copy link
Contributor

@jjaffeux jjaffeux commented Oct 1, 2019

No description provided.

@discoursebot
Copy link

You've signed the CLA, jjaffeux. Thank you! This pull request is ready for review.

@jjaffeux
Copy link
Contributor Author

jjaffeux commented Oct 1, 2019

@eviltrout note I couldn't find where is this notify: false used, do you know ?

@SamSaffron
Copy link
Member

This is a walk down memory lane:

https://github.com/discourse/discourse/blame/b9ccf4d09c62fd87a3be0bd42ecd3ed036dd6129/app/assets/javascripts/discourse.js

We used to put (*) topic title for certain cases, something that we totally stopped doing.

Merging this in!

@SamSaffron SamSaffron merged commit 6e815ba into discourse:master Oct 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eviltrout eviltrout Awaiting requested review from eviltrout

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jjaffeux @discoursebot @SamSaffron