UX: Better composer hyperlink modal #8160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You've signed the CLA, pmusaraj. Thank you! This pull request is ready for review. |
CvX
reviewed
Oct 5, 2019
app/assets/javascripts/discourse/controllers/insert-hyperlink.js.es6
Outdated
Show resolved
Hide resolved
CvX
reviewed
Oct 5, 2019
| @@ -0,0 +1,47 @@ | |||
| import ModalFunctionality from "discourse/mixins/modal-functionality"; | |||
| import { default as computed } from "ember-addons/ember-computed-decorators"; | |||
There was a problem hiding this comment.
ESLint error, computed is no longer used: https://travis-ci.org/discourse/discourse/jobs/593993307#L701-L702
|
I support this cleanup, feel free to merge! |
|
@pmusaraj It seems it's no longer possible to submit the form by pressing enter/return. Could this PR be the cause? |
|
Yes, it’s possible. I think our modals in general do not submit on return, I think we should fix that globally. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This brings the hyperlink modal in line with all other modals (upload, date, etc.) by placing the fixed modal element outside of the composer.
Before:
After: