Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve spam_hosts copy #8203

Merged
merged 1 commit into from Oct 18, 2019
Merged

Improve spam_hosts copy #8203

merged 1 commit into from Oct 18, 2019

Conversation

@tshenry
Copy link
Member

tshenry commented Oct 16, 2019

The domain included in the spam_hosts copy is confusing as it refers to a link in the post that is being reviewed, not the link that caused all of the user's posts with links to end up in the review queue. For now, it's easiest to remove the domain altogether and add a little more text to describe what the posts ended up in the review queue. For more context see: https://meta.discourse.org/t/white-listed-spam-host-domains-setting-not-being-honoured-for-new-users/130348

Changes include

  • Increase size of the reviewable's conversation excerpt to prevent truncation of the new copy
  • Remove the domain parameter from the flag_linked_posts_as_spam method in the user model since it is no longer needed
  • Remove the domain interpolation variable from all translation files
  • Add "All posts from this user that include links should be reviewed." to server.en.yml for added clarity on why the posts entered the queue

Result looks like:

Screen Shot 2019-10-16 at 11 06 24 AM

- Increase size of the reviewable's conversation excerpt to prevent truncation of the new copy
- Remove the `domain` parameter from the `flag_linked_posts_as_spam` method in the user model since it is no longer needed
- Remove the `domain` interpolation variable from all translation files
- Add "All posts from this user that include links should be reviewed." to server.en.yml for added clarity on why the posts entered the queue
@discoursebot

This comment has been minimized.

Copy link

discoursebot commented Oct 16, 2019

You've signed the CLA, tshenry. Thank you! This pull request is ready for review.

@tshenry tshenry requested a review from eviltrout Oct 16, 2019
Copy link
Member

eviltrout left a comment

This looks good to me. However, generally we only update English. Is there a problem if we update these @nlalonde ?

@nlalonde

This comment has been minimized.

Copy link
Member

nlalonde commented Oct 17, 2019

It's not a problem, and I think you have to edit them in this case because they have an interpolation that won't work anymore. Transifex will mark them as needing translation again, so they won't be pulled back in until they're updated by translators.

@tshenry tshenry merged commit 95114f8 into discourse:master Oct 18, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@tshenry tshenry deleted the tshenry:spam_hosts_update branch Oct 18, 2019
@discoursebot

This comment has been minimized.

Copy link

discoursebot commented Oct 18, 2019

This pull request has been mentioned on Discourse Meta. There might be relevant details there:

https://meta.discourse.org/t/white-listed-spam-host-domains-setting-not-being-honoured-for-new-users/130348/12

3 similar comments
@discoursebot

This comment has been minimized.

Copy link

discoursebot commented Oct 18, 2019

This pull request has been mentioned on Discourse Meta. There might be relevant details there:

https://meta.discourse.org/t/white-listed-spam-host-domains-setting-not-being-honoured-for-new-users/130348/12

@discoursebot

This comment has been minimized.

Copy link

discoursebot commented Oct 18, 2019

This pull request has been mentioned on Discourse Meta. There might be relevant details there:

https://meta.discourse.org/t/white-listed-spam-host-domains-setting-not-being-honoured-for-new-users/130348/12

@discoursebot

This comment has been minimized.

Copy link

discoursebot commented Oct 18, 2019

This pull request has been mentioned on Discourse Meta. There might be relevant details there:

https://meta.discourse.org/t/white-listed-spam-host-domains-setting-not-being-honoured-for-new-users/130348/12

CvX added a commit to discourse/discourse-github that referenced this pull request Oct 21, 2019
* DEV: Don't post multiple linkbacks for the same PR

If a post contained any variants of PR URL like:

https://github.com/CvX/discourse/pull/8203/commits
https://github.com/CvX/discourse/pull/8203/files
https://github.com/CvX/discourse/pull/8203/checks

…the plugin would create an extra linkback every time you'd run the job (i.e. the job was unintentionally non-idempotent)

An example of duplicated @discoursebot comments: discourse/discourse#8203 (comment)

* DEV: Don't create jobs for posts that only mention "github"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
You can’t perform that action at this time.