Improve spam_hosts copy #8203
Merged
Improve spam_hosts copy #8203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Increase size of the reviewable's conversation excerpt to prevent truncation of the new copy - Remove the `domain` parameter from the `flag_linked_posts_as_spam` method in the user model since it is no longer needed - Remove the `domain` interpolation variable from all translation files - Add "All posts from this user that include links should be reviewed." to server.en.yml for added clarity on why the posts entered the queue
|
You've signed the CLA, tshenry. Thank you! This pull request is ready for review. |
|
It's not a problem, and I think you have to edit them in this case because they have an interpolation that won't work anymore. Transifex will mark them as needing translation again, so they won't be pulled back in until they're updated by translators. |
|
This pull request has been mentioned on Discourse Meta. There might be relevant details there: |
3 similar comments
|
This pull request has been mentioned on Discourse Meta. There might be relevant details there: |
|
This pull request has been mentioned on Discourse Meta. There might be relevant details there: |
|
This pull request has been mentioned on Discourse Meta. There might be relevant details there: |
CvX
added a commit
to discourse/discourse-github
that referenced
this pull request
Oct 21, 2019
* DEV: Don't post multiple linkbacks for the same PR If a post contained any variants of PR URL like: https://github.com/CvX/discourse/pull/8203/commits https://github.com/CvX/discourse/pull/8203/files https://github.com/CvX/discourse/pull/8203/checks …the plugin would create an extra linkback every time you'd run the job (i.e. the job was unintentionally non-idempotent) An example of duplicated @discoursebot comments: discourse/discourse#8203 (comment) * DEV: Don't create jobs for posts that only mention "github"
CvX
added a commit
that referenced
this pull request
May 6, 2024
Previously, if you supplied your own content to DButton it would still add the character: ```hbs <DButton>my text</DButton> ``` ```html <button>​ my text</button> ```
CvX
added a commit
that referenced
this pull request
May 6, 2024
Previously, if you supplied your own content to DButton it would still add the character: ```hbs <DButton>my text</DButton> ``` ```html <button>​ my text</button> ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The domain included in the
spam_hostscopy is confusing as it refers to a link in the post that is being reviewed, not the link that caused all of the user's posts with links to end up in the review queue. For now, it's easiest to remove the domain altogether and add a little more text to describe what the posts ended up in the review queue. For more context see: https://meta.discourse.org/t/white-listed-spam-host-domains-setting-not-being-honoured-for-new-users/130348Changes include
domainparameter from theflag_linked_posts_as_spammethod in the user model since it is no longer neededdomaininterpolation variable from all translation filesResult looks like: