FIX: You can't change a subject whilst Flagging #907
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Meta: [You can't change a subject whilst Flagging](http://meta.discourse.org/t/you-can-t-change-a-subject-whilst-flagging/6887) This revert a change made by @eviltrout in b794830 in the `flag_view.js`. The `Em.run.schedule('afterRender', function() {...})` is apparently not enough. Had to schedule the event on the next run loop. Hopefully, the PR emberjs/ember.js#1235 will soon be merged in and we'll have a proper radio button control in Ember.js.
|
You've signed the CLA, ZogStriP. Thank you! This pull request is ready for review. |
eviltrout
added a commit
that referenced
this pull request
May 27, 2013
…hilst-flagging FIX: You can't change a subject whilst Flagging
|
Oops I didn't try to do that myself! Good catch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Meta: You can't change a subject whilst Flagging
This revert a change made by @eviltrout in b794830 in the
flag_view.js.The
Em.run.schedule('afterRender', function() {...})is apparently not enough. Had to schedule the event on the next run loop.Hopefully, the PR emberjs/ember.js#1235 will soon be merged in and we'll have a proper radio button control in Ember.js.