Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX: Toggle bookmark for topic was not working after cancelling the modal #9418

Merged
merged 2 commits into from
Apr 14, 2020
Merged

FIX: Toggle bookmark for topic was not working after cancelling the modal #9418

merged 2 commits into from
Apr 14, 2020

Conversation

martin-brennan
Copy link
Contributor

@martin-brennan martin-brennan commented Apr 14, 2020 •
edited
Loading

  • When bookmarking the topic, if the user cancelled the bookmark modal the bookmark topic button no longer worked because we did not reset the "bookmarked" property
  • Prefill the custom reminder time to 8:00am

@martin-brennan martin-brennan merged commit 2d122f0 into master Apr 14, 2020
@martin-brennan martin-brennan deleted the issue/fix-toggle-bookmark branch April 14, 2020 05:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@martin-brennan