FEATURE: Edit bookmark reminders from post and explicit delete button #9455
Conversation
* when created return new bookmark id in response * serialize bookmark name and reminder at for post for editing post bookmark
* return whether topic_bookmarked is true from bookmark manager * move old after delete code for post into an afterDelete callback
|
@coding-horror moved your comment here, I had to close that other PR because weird stuff was happening
Will do! |
| this.deleting = true; | ||
| bootbox.confirm(I18n.t("bookmarks.confirm_delete"), result => { | ||
| if (result) { | ||
| this.closeWithoutSaving = true; |
There was a problem hiding this comment.
I know this variable didn't start in this commit but as a general note - if you are only using a variable in a particular controller, and nothing is computed based on it, we prefer to underscore them as private. For example this._closeWithoutSaving.
Absolutely a minor thing, though and just something to keep in mind for the future.
There was a problem hiding this comment.
@eviltrout cool I was talking to Joffrey about this as well RE: functions because I wasn't sure, so I will make sure to do it from now on :)
There is now an explicit "Delete Bookmark" button in the edit modal:
A confirmation is shown before deleting
Along with this, when the bookmarked post icon is clicked the modal is now shown instead of just deleting the bookmark. Also, the "Delete Bookmark" button from the user bookmark list now confirms the action.
Add a
d dshortcut in the modal to delete the bookmark.