Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX: Don't raise an exception if a topic cannot be retrieved #9906

Merged
merged 1 commit into from
May 28, 2020
Merged

FIX: Don't raise an exception if a topic cannot be retrieved #9906

merged 1 commit into from
May 28, 2020

Conversation

romanrizzi
Copy link
Member

Trying to retrieve a post with a non-existent URL will raise an exception every time, flooding our logs.

Should we set a rate limit in the EmbedsController#comments method when the URL cannot be retrieved?

@romanrizzi romanrizzi requested a review from eviltrout May 28, 2020 14:35
@romanrizzi romanrizzi merged commit a414768 into discourse:master May 28, 2020
@romanrizzi romanrizzi deleted the topic_retriever branch May 28, 2020 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eviltrout eviltrout eviltrout approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@romanrizzi @eviltrout