Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use latest docker garbage collector #416

Closed
wants to merge 1 commit into from
Closed

Use latest docker garbage collector #416

wants to merge 1 commit into from

Conversation

sau226
Copy link
Contributor

@sau226 sau226 commented Jan 4, 2019

This patch configures discourse_docker to use the latest docker_gc version as the version we use was last updated 3 years ago and (in my opinion) a bit slow compared with this version.

@SamSaffron
Copy link
Member

@xfalcox should we just pull out docker gc and use the docker built in thing?

@sau226 sau226 closed this Jan 22, 2019
@sau226
Copy link
Contributor Author

sau226 commented Jan 22, 2019

Sorry had to sync my local branch. Reopening

@sau226 sau226 reopened this Jan 22, 2019
@sau226 sau226 closed this Jan 23, 2019
@sau226
Copy link
Contributor Author

sau226 commented Jan 23, 2019

That was another forced push (it closes automatically always for some reason). I just toggled allow edits from maintainers (in case you need to update my fork) and will reopen this PR soon

@sau226 sau226 reopened this Jan 23, 2019
@sau226
Copy link
Contributor Author

sau226 commented Feb 12, 2019

@xfalcox Hiya,

Could you please review this some time to see if docker-gc is still needed?

Regards,

sau226

P.S: Sorry if this request or any of the previous ones are of any inconvenience.

@SamSaffron
Copy link
Member

@sau226 I would far prefer a PR that swaps out docker gc and instead has ./launcher cleanup simply invoke docker system prune

@SamSaffron SamSaffron closed this Feb 12, 2019
@sau226 sau226 mentioned this pull request Feb 13, 2019
@sau226
Copy link
Contributor Author

sau226 commented Feb 13, 2019

@SamSaffron Thanks for the heads up. I've created PR 420 to implement the changes. Please feel free to review that when you're ready.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants