Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
we are maintaining an image for kubernetes, and basically, we put together:
But, we don't consider container as slim VMs, but we consider them as "fat" binairies.
As such, we don't use tools like ssh, postgres, redis and so on.
I think in the best world, we'd share a base image that could be suitable for you and us.
But in the mean time, if we could reorganize just a bit this docker image, this would help us follow changes.
Bascially, we don't need this block:
https://github.com/pierreozoux/discourse_docker/blob/patch-1/image/base/slim.Dockerfile#L20-L46
and this block:
https://github.com/pierreozoux/discourse_docker/blob/patch-1/image/base/slim.Dockerfile#L87-L95
Maybe the way we propose is not perfect, but this is to eventually start the discussion?
Thanks for your time and have a nice day!