Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Funny Or Die onebox #100

Merged
merged 5 commits into from
Aug 28, 2013
Merged

Create Funny Or Die onebox #100

merged 5 commits into from
Aug 28, 2013

Conversation

jzeta
Copy link
Contributor

@jzeta jzeta commented Aug 28, 2013

No description provided.

@ghost ghost assigned vykster Aug 28, 2013
@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling fb01914 on add-funny-or-die-onebox into a12731a on master.

vykster added a commit that referenced this pull request Aug 28, 2013
@vykster vykster merged commit f41c29c into master Aug 28, 2013
@vykster vykster deleted the add-funny-or-die-onebox branch August 28, 2013 06:18
@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 6b11919 on add-funny-or-die-onebox into a12731a on master.

include OpenGraph

matches do
# /^https?\:\/\/(www\.)?funnyordie\.com\/videos\/.*$/$/

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've been adding the Discourse regex to all the oneboxes, commented out. Should I stop doing that then?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll be deleting them after we properly implement them w/ Verbal Expressions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants