Caching support for preview #97
Conversation
|
Exploring https://github.com/minad/moneta for setting cache expire times. |
| @@ -11,7 +12,7 @@ | |||
| require_relative "onebox/engine" | |||
|
|
|||
| module Onebox | |||
| def self.preview(url, args={}) | |||
| Preview.new(url, args) | |||
| def self.preview(url, options = { cache: Hash.new }) | |||
There was a problem hiding this comment.
We should move this default somewhere, like a singleton method. Something like:
def self.defaults
{
cache: Hash.new
}
end
| end | ||
|
|
||
| def raw | ||
| @raw ||= Nokogiri::HTML(open(@url)) |
There was a problem hiding this comment.
Lets move this into it's the HTML module, just like the Onebox module. That means we'll need to change this to
def raw
raise NoMethodError, "your engine needs to implement this method"
endand then write a test that makes sure this method doesn't raise an error, just like data.
You'll also need to include HTML into all the oneboxes that just use nokogiri.
There was a problem hiding this comment.
Also write some documentation on what this method needs to do on individual types of engines.
There was a problem hiding this comment.
Should we test HTML in engine_spec.rb then? Or have a HTML spec? We don't have one currently for OpenGraph...
There was a problem hiding this comment.
Yes, excellent idea.
And we should.
|
Yeah! |
No description provided.