FIX: sidekiq stats collector memory leak #256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh ... nice catch, thanks for fixing! |
SamSaffron
approved these changes
Nov 16, 2022
|
Let me know that this resolves the issue, once confirmed I will push out a release. |
Hi @SamSaffron , thanks for the fast reply. Sure, gonna test it. I will notify to you with the results. |
|
Hello @SamSaffron , after some tests, seems that the problem has been fixed, so I guess that you can push out a release. Thanks! |
|
cool, will push a new release today, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We also experienced the problem explained in #240 , in which metrics present in the
sidekiqstats collector started to grow and saturated the process (used all CPU assigned to it).This PR aims to clean old metrics, as sidekiq_queue_collector.rb does.