Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adding hackathon prize vc schema #70

Merged
merged 2 commits into from
Jul 19, 2023
Merged

Conversation

ericc572
Copy link
Contributor

Adding Hackathon Prize/Rank Credential for Foundance, to attest to specific Ranking + Prizes.

Suggestion was to make a new schema instead of reissuing Proof Of Hack N # of times.

@ericc572 ericc572 requested a review from sruddy July 11, 2023 15:58
Copy link
Contributor

@sruddy sruddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this only for programatic? If not can you add to https://github.com/discoxyz/disco-schemas/blob/main/src/schemas/index.ts

eventDate: { title: "Event Date", type: "string", format: "date" },
track: { title: "Track/Category", type: "string"},
bounty: { title: "Bounty", type: "string"},
Prize: { title: "Prize", type: "string"},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you lowercase Prize

required: ["id"],
properties: {
id: { title: "Recipient DID", type: "string", format: "uri" },
eventName: { title: "Event Name", type: "string" },
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there's a double space here

@ericc572 ericc572 requested a review from sruddy July 11, 2023 18:10
@sruddy sruddy merged commit de4e0a0 into main Jul 19, 2023
@probablynothingdevops
Copy link
Collaborator

🎉 This PR is included in version 1.8.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants