-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: adding hackathon prize vc schema #70
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this only for programatic? If not can you add to https://github.com/discoxyz/disco-schemas/blob/main/src/schemas/index.ts
eventDate: { title: "Event Date", type: "string", format: "date" }, | ||
track: { title: "Track/Category", type: "string"}, | ||
bounty: { title: "Bounty", type: "string"}, | ||
Prize: { title: "Prize", type: "string"}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you lowercase Prize
required: ["id"], | ||
properties: { | ||
id: { title: "Recipient DID", type: "string", format: "uri" }, | ||
eventName: { title: "Event Name", type: "string" }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like there's a double space here
649cec1
to
405c699
Compare
🎉 This PR is included in version 1.8.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Adding Hackathon Prize/Rank Credential for Foundance, to attest to specific Ranking + Prizes.
Suggestion was to make a new schema instead of reissuing Proof Of Hack N # of times.