Disable validation of output smithy files by default. #219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes the tool a little bit more lenient for some users. A flag is added to re-enable validation.
…of-output-smithy-files
Merged
daddykotex
reviewed
Dec 7, 2023
| @@ -64,7 +64,7 @@ _Note: this library is published to work on Java 8 and above. However, you will | |||
| ### CLI Usage | |||
|
|
|||
| The `smithytranslate` CLI will recursively go through all child directories of the | |||
| input directory provided and format any Smithy files it finds. The output | |||
| input directory provided and format any Smithy files it finds. The output | |||
There was a problem hiding this comment.
unrelated to your PR, but it seems like the output is just a leftover incomplete sentence
daddykotex
reviewed
Dec 7, 2023
| @@ -123,13 +123,15 @@ Options and flags: | |||
| Display this help text. | |||
| --input <path>, -i <path> | |||
| input source files | |||
| --verboseNames | |||
There was a problem hiding this comment.
thanks for aligning all CLI options on kebab
daddykotex
approved these changes
Dec 7, 2023
lewisjkl
approved these changes
Dec 7, 2023
Baccata
deleted the
allow-for-avoiding-validation-of-output-smithy-files
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the tool a little bit more lenient for some users. A flag is added to re-enable validation.
also changes the CLI options to be kebab-cased
Todo