remove generation of redundant package imports #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Baccata
reviewed
Feb 8, 2022
| @@ -43,8 +43,7 @@ object Renderable { | |||
|
|
|||
| implicit def tupleRenderable[A](implicit | |||
| A: Renderable[A] | |||
| ): Renderable[(String, A)] = (t: (String, A)) => | |||
| A.render(t._2).addImport(t._1) | |||
| ): Renderable[(String, A)] = (t: (String, A)) => A.render(t._2) | |||
There was a problem hiding this comment.
I find this suspicious. The LHS of the tuple isn't used anymore, which means that this week's implicit is probably useless and its current usesites should be amended
There was a problem hiding this comment.
That's fair, I will go through and cleanup the usesites
There was a problem hiding this comment.
Lol, that's what happens when I look at github on the phone whilst being sleep deprived 😄
kubukoz
approved these changes
Feb 9, 2022
Baccata
approved these changes
Feb 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #101.