[0.18] Fix ClassCastException in document encoding #1159
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1158.
As far as I understand,
case x: ArraySeq[Document]
isn't actually doing a class check because of type erasure.The unsafe array inside turns out to actually be an
Array[Object]
, so casting it toArray[Document]
throws because arrays aren't erased (unlikeArraySeq
which is a normal generic class).I'm sure this solution is a bit inefficient, another one I had in mind would confirm the identity of the wrapped array:
but I'm not sure it's better as I didn't run any benchmarks. @plokhotnyuk any thoughts on this PR?
Note: the fix for the issue should be backported to 0.17.
EDIT: updated the implementation to be closer to the original, just checking for empty arrays instead. Perhaps it's worth a property-based test of roundtripping arbitrary documents just in case.