Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo in creating-your-own-traits #1350

Merged
merged 1 commit into from
Jan 9, 2024
Merged

Fix typo in creating-your-own-traits #1350

merged 1 commit into from
Jan 9, 2024

Conversation

valencik
Copy link
Contributor

@valencik valencik commented Jan 9, 2024

Minor PR fixing a typo on the selector in the creating-your-own-traits section.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

1 similar comment
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@kubukoz kubukoz merged commit 8e3dc3a into disneystreaming:series/0.18 Jan 9, 2024
10 of 11 checks passed
daddykotex pushed a commit that referenced this pull request Jan 11, 2024
@valencik @daddykotex
Fix typo in creating-your-own-traits (#1350)
10b4324 
if not filtered, it could fail like:

```
[info] [error] java.util.zip.ZipException: zip END header not found
[info] [error]  at java.base/java.util.zip.ZipFile$Source.findEND(ZipFile.java:1469)
[info] [error]  at java.base/java.util.zip.ZipFile$Source.initCEN(ZipFile.java:1477)
[info] [error]  at java.base/java.util.zip.ZipFile$Source.<init>(ZipFile.java:1315)
[info] [error]  at java.base/java.util.zip.ZipFile$Source.get(ZipFile.java:1277)
[info] [error]  at java.base/java.util.zip.ZipFile$CleanableResource.<init>(ZipFile.java:709)
[info] [error]  at java.base/java.util.zip.ZipFile.<init>(ZipFile.java:243)
[info] [error]  at java.base/java.util.zip.ZipFile.<init>(ZipFile.java:172)
[info] [error]  at java.base/java.util.jar.JarFile.<init>(JarFile.java:347)
[info] [error]  at java.base/java.util.jar.JarFile.<init>(JarFile.java:318)
[info] [error]  at java.base/java.util.jar.JarFile.<init>(JarFile.java:284)
[info] [error]  at smithy4s.codegen.JarUtils$.extractJarManifestAttribute(JarUtils.scala:24)
[info] [error]  at smithy4s.codegen.JarUtils$.extractSmithy4sDependencies(JarUtils.scala:31)
[info] [error]  at smithy4s.codegen.Smithy4sCodegenPlugin$.extractJar(Smithy4sCodegenPlugin.scala:392)
[info] [error]  at smithy4s.codegen.Smithy4sCodegenPlugin$.$anonfun$defaultSettings$19(Smithy4sCodegenPlugin.scala:214)
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kubukoz kubukoz kubukoz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@valencik @CLAassistant @kubukoz