Support @httpResponseCode over newtypes
#1377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kubukoz
reviewed
Jan 25, 2024
modules/core/src/smithy4s/http/internals/HttpResponseCodeSchemaVisitor.scala
Show resolved
Hide resolved
No particular reason, sometimes we just miss things |
kubukoz
approved these changes
Jan 26, 2024
|
gah, I forgot the CHANGELOG. @miguel-vila please check the PR template next time 😅 |
kubukoz
added a commit
that referenced
this pull request
Jan 26, 2024
kubukoz
added a commit
that referenced
this pull request
Jan 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
not sure if there was a reason to miss this case, let me know what u think