Adds Handlers constructs and functions #1522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds functionality to facilitate the decoupled implementation of individual operations. Using these constructs allow to split the dependencies needed for the implementation of each operation, and move the coupling closer to the "end-of-the-world".
kubukoz
reviewed
May 15, 2024
| ): AsService[Alg, F] = | ||
| new EndpointHandler.AsServiceImpl[Alg, Op, F](this, service) | ||
|
|
||
| final def orElse(other: EndpointHandler[Op, F]): EndpointHandler[Op, F] = |
There was a problem hiding this comment.
nitpick: orElse is used in cats/CE for error handling and could be confusing, perhaps we can find a name that isn't, e.g. just or?
other ideas off the top of my head: merge, add, combine
|
I like that this is lightweight on changes to existing code |
Co-authored-by: Jakub Kozłowski <kubukoz@gmail.com>
kubukoz
approved these changes
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds functionality to facilitate the decoupled implementation of individual operations. Using these constructs allow to split the dependencies needed for the implementation of each operation, and move the coupling closer to the "end-of-the-world".
PR Checklist (not all items are relevant to all PRs)