DocumentKeyDecoder and DocumentKeyEncoder #311

daddykotex · 2022-07-13T14:14:20Z

This is an attempt at #296 (comment) following @Baccata's initial advice.

I mark it as WIP because I'm not sure of the following:

I had to implement the surject/biject/lazy for the decoder but not the encoder
I did not integrate with the SchemaVisitorJCodec which I think I need to do (if I have the right approach)

modules/core/src/smithy4s/internals/KeyDecoder.scala

modules/core/src/smithy4s/internals/DocumentEncoderSchemaVisitor.scala

daddykotex added 2 commits July 13, 2022 10:11

Get rid of canBeKey in favor of a KeyEncoder

7a620ad

Get rid of canBeKey in favor of a KeyDecoder

fa19052

daddykotex requested a review from Baccata July 13, 2022 14:14

daddykotex marked this pull request as draft July 13, 2022 14:14

kubukoz reviewed Jul 13, 2022

View reviewed changes

modules/core/src/smithy4s/internals/KeyDecoder.scala Outdated Show resolved Hide resolved

daddykotex added 2 commits July 21, 2022 16:10

Merge remote-tracking branch 'origin/main' into dfrancoeur/key-enc-dec

5643003

Renamed to DocumentKey*

37dd776

daddykotex changed the title ~~WIP: KeyDecoder and KeyEncoder~~ DocumentKeyDecoder and DocumentKeyEncoder Jul 22, 2022

daddykotex marked this pull request as ready for review July 22, 2022 12:56

Baccata reviewed Jul 27, 2022

View reviewed changes

modules/core/src/smithy4s/internals/DocumentEncoderSchemaVisitor.scala Outdated Show resolved Hide resolved

daddykotex added 2 commits August 15, 2022 08:43

Merge remote-tracking branch 'origin/main' into dfrancoeur/key-enc-dec

2bcd094

Refactor map implementation

6eb0ec5

Baccata approved these changes Aug 16, 2022

View reviewed changes

Baccata merged commit 1adb13a into main Aug 16, 2022

Baccata deleted the dfrancoeur/key-enc-dec branch August 16, 2022 16:01

Provide feedback