Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
First draft of the mill plugin for smithy4s #450
First draft of the mill plugin for smithy4s #450
Changes from 9 commits
61f4be8
d8c7cb2
1d8b18f
fa2bcbf
826776a
a50ef9b
e50a94c
6df6821
492b2a8
d40cbb6
5b6fa72
8077c7e
38830e3
3715a70
0959ba3
ab4cd3c
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changed from
os.pwd
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also the
implicit FullName
here is rather pointlessI'd rather have the evaluator for
foo
to write infoo
in this example if I don't provide it, it writes to
barEv
and if you have multiple tests that use an evaluator with the same name, they write to the sameout
directory.I think this is more a criticism of https://github.com/com-lihaoyi/mill/pull/1893/files rather than this PR though
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
UX can be improved as we learn more by using it. MiMa has not been set on this module, specifically to be able to iterate.