Add error-related transformations + documentation #584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Baccata
force-pushed
the
transformation-documentation
branch
from
c3903b5
to
ae72f43
Compare
lewisjkl
approved these changes
Nov 9, 2022
daddykotex
reviewed
Nov 9, 2022
| * // assuming Foo is a code-generated interface | ||
| * val fooOption : Foo[Option] = ??? | ||
| * val toList = new smithy4s.PolyFunction[Option, List]{def apply[A](fa: Option[A]): List[A] = fa.toList} | ||
| * fooOption = foo.transform(toList) |
There was a problem hiding this comment.
Suggested change
| * fooOption = foo.transform(toList) | |
| * val fooList: Foo[List] = foo.transform(toList) |
daddykotex
reviewed
Nov 9, 2022
| } | ||
|
|
||
| /** | ||
| * A transformation that turns a bifunctor algebra into a monofunctor algebra by lifting absorbing known errors in a |
There was a problem hiding this comment.
Suggested change
| * A transformation that turns a bifunctor algebra into a monofunctor algebra by lifting absorbing known errors in a | |
| * A transformation that turns a bifunctor algebra into a monofunctor algebra by absorbing known errors in a |
kubukoz
previously requested changes
Nov 9, 2022
Comment on lines
+1000
to
+1001
| // If the path is a directory, we get the hashes of all files | ||
| // then hash the concatenation of the hash's bytes. |
There was a problem hiding this comment.
That's because it's also in the SBT plugin built by this project.
| message: String | ||
| } | ||
| } | ||
| ```scala mdoc:passthrough |
kubukoz
approved these changes
Nov 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
smithy4spackage. I think it was a mistake for me to move it, and now the companion object contains constructs that could be more user-facing.WithErrortype alias.Transformation.AbsorbErrorandTransformation.SurfaceError+ tests . This will help EitherT/MonixBIO/ZIO users.