fix path segment parsing when suffixed with query #689
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daddykotex
reviewed
Dec 20, 2022
| else if (str.startsWith("{") && str.endsWith("}")) | ||
| Some(PathSegment.label(str.substring(1, str.length() - 1))) | ||
| else Some(PathSegment.static(str)) | ||
| Option(str).map { str => |
There was a problem hiding this comment.
I think you got rid of a .isEmpty() here
you may want to reintroduce it as a .filter(_.nonEmpty) on the Option
There was a problem hiding this comment.
ah yes , was thinking of Null , will update
kubukoz
reviewed
Dec 20, 2022
PathSegment implementation returns just the path, minus any query parameters A staticQueryParams method has been added HttpEndpoint, the Http4s client calls that method to retrieve any static query params and pass them on Tests: metadata.smithy has been modified and PathSpec includes tests for testing the HttpEndpoint functionality
Baccata
reviewed
Jan 5, 2023
Baccata
reviewed
Jan 5, 2023
| val uri = baseUri | ||
| .copy(path = baseUri.path.addSegments(path.map(Uri.Path.Segment(_)))) | ||
| .withQueryParams(staticQueries) |
Baccata
reviewed
Jan 5, 2023
Baccata
reviewed
Jan 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the scenario of a constant query (and perhaps some other cases) parsing of path segments fail.
http://yourhost/my/uri/{foo}?hello=worldshould parse a label foo, which it currently does not