Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix path segment parsing when suffixed with query #689

Merged
merged 8 commits into from
Jan 5, 2023
Merged

fix path segment parsing when suffixed with query #689

merged 8 commits into from
Jan 5, 2023

Commits on Dec 20, 2022

  1. fix path segment parsing when suffixed with query

    @yisraelU
    yisraelU committed Dec 20, 2022
    Configuration menu
    Copy the full SHA
    2869d53 View commit details
    Browse the repository at this point in the history

  2. add back filtering for non emptiness on string

    @yisraelU
    yisraelU committed Dec 20, 2022
    Configuration menu
    Copy the full SHA
    98a4a28 View commit details
    Browse the repository at this point in the history

Commits on Dec 21, 2022

  1. adds separate test for parsing path params from path with query params

    @yisraelU
    yisraelU committed Dec 21, 2022
    Configuration menu
    Copy the full SHA
    2c167c8 View commit details
    Browse the repository at this point in the history

Commits on Jan 4, 2023

  1. Changes: 

    PathSegment implementation returns just the path, minus any query parameters
A  staticQueryParams method has been added  HttpEndpoint,
the Http4s client calls that method to retrieve any static query params and pass them on

Tests: metadata.smithy has been modified and PathSpec includes tests for testing the HttpEndpoint functionality
    @yisraelU
    yisraelU committed Jan 4, 2023
    Configuration menu
    Copy the full SHA
    21ba6e0 View commit details
    Browse the repository at this point in the history

  2. formatting

    @yisraelU
    yisraelU committed Jan 4, 2023
    Configuration menu
    Copy the full SHA
    f70d3cb View commit details
    Browse the repository at this point in the history

Commits on Jan 5, 2023

  1. revert staticQueryParams to Map[String,Seq[String]] for future proofi… 

    …ng sake
    @yisraelU
    yisraelU committed Jan 5, 2023
    Configuration menu
    Copy the full SHA
    151f719 View commit details
    Browse the repository at this point in the history

  2. fix test for new statiq query params interface

    @yisraelU
    yisraelU committed Jan 5, 2023
    Configuration menu
    Copy the full SHA
    7bff3d8 View commit details
    Browse the repository at this point in the history

  3. removed extra allocations

    @yisraelU
    yisraelU committed Jan 5, 2023
    Configuration menu
    Copy the full SHA
    9a014a6 View commit details
    Browse the repository at this point in the history