Tracking errors and properly exiting with error code #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JordanFaust
reviewed
Aug 17, 2020
JordanFaust
approved these changes
Aug 21, 2020
ncatelli
reviewed
Aug 24, 2020
| func (results *ResultSafe) Add(result *Result) { | ||
| results.Lock() | ||
| results.InvocationResults = append(results.InvocationResults, result) | ||
| results.Unlock() |
There was a problem hiding this comment.
Unimportant potentially bikesheddy question so take worth a grain of salt, do we prefer defer for these kinda ops?
There was a problem hiding this comment.
I generally prefer using defer but considering the proximity and how simple this function is I am impartial to its use here. When there is more code between the lock and unlock I think defer is always the best option
ncatelli
approved these changes
Aug 31, 2020
JordanFaust
approved these changes
Aug 31, 2020
sendqueery
approved these changes
Sep 1, 2020
| @@ -114,12 +114,18 @@ func runCommand(cmd *cobra.Command, args []string) { | |||
| // Output our results | |||
| log.Infof(resultFormat, "Instance ID", "Region", "Profile", "Status") | |||
| for _, v := range output.InvocationResults { | |||
| switch v.Status { | |||
There was a problem hiding this comment.
Is there a particular reason to move away from the switch/case statements?
There was a problem hiding this comment.
Jordan and I paired on this. Not sure why I made the change either
sendqueery
pushed a commit
that referenced
this pull request
Sep 3, 2020
Co-authored-by: Josh Schell <joshua.schell@disneystreaming.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure errors tracked to later exit properly with error code (1)
(wip)