Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update minimal version to go 1.16 #65

Merged
merged 2 commits into from
May 24, 2022
Merged

Update minimal version to go 1.16 #65

merged 2 commits into from
May 24, 2022

Conversation

ncatelli
Copy link
Contributor

@ncatelli ncatelli commented May 20, 2022

General

This PR bumps the minimum version of go to 1.16 in both go mod and the build jobs to resolve an issue where some of our mac users are impacted by golang/go#49219.

Testing

Prior to these changes:

$> go version
go version go1.18.2 darwin/amd64
$> CGO_ENABLED=0 go build -o bin/ssm main.go
# [golang.org/x/sys/unix](http://golang.org/x/sys/unix)
../../../go/pkg/mod/golang.org/x/sys@v0.0.0-20200625212154-ddb9806d33ae/unix/syscall_darwin.1_13.go:29:3: //go:linkname must refer to declared function or variable
../../../go/pkg/mod/golang.org/x/sys@v0.0.0-20200625212154-ddb9806d33ae/unix/zsyscall_darwin_amd64.1_13.go:27:3: //go:linkname must refer to declared function or variable
../../../go/pkg/mod/golang.org/x/sys@v0.0.0-20200625212154-ddb9806d33ae/unix/zsyscall_darwin_amd64.1_13.go:40:3: //go:linkname must refer to declared function or variable
../../../go/pkg/mod/golang.org/x/sys@v0.0.0-20200625212154-ddb9806d33ae/unix/zsyscall_darwin_amd64.go:28:3: //go:linkname must refer to declared function or variable
../../../go/pkg/mod/golang.org/x/sys@v0.0.0-20200625212154-ddb9806d33ae/unix/zsyscall_darwin_amd64.go:43:3: //go:linkname must refer to declared function or variable
../../../go/pkg/mod/golang.org/x/sys@v0.0.0-20200625212154-ddb9806d33ae/unix/zsyscall_darwin_amd64.go:59:3: //go:linkname must refer to declared function or variable
../../../go/pkg/mod/golang.org/x/sys@v0.0.0-20200625212154-ddb9806d33ae/unix/zsyscall_darwin_amd64.go:75:3: //go:linkname must refer to declared function or variable
../../../go/pkg/mod/golang.org/x/sys@v0.0.0-20200625212154-ddb9806d33ae/unix/zsyscall_darwin_amd64.go:90:3: //go:linkname must refer to declared function or variable
../../../go/pkg/mod/golang.org/x/sys@v0.0.0-20200625212154-ddb9806d33ae/unix/zsyscall_darwin_amd64.go:105:3: //go:linkname must refer to declared function or variable
../../../go/pkg/mod/golang.org/x/sys@v0.0.0-20200625212154-ddb9806d33ae/unix/zsyscall_darwin_amd64.go:121:3: //go:linkname must refer to declared function or variable
../../../go/pkg/mod/golang.org/x/sys@v0.0.0-20200625212154-ddb9806d33ae/unix/zsyscall_darwin_amd64.go:121:3: too many errors

After dep update, builds pass:

$> CGO_ENABLED=0 go build -o bin/ssm main.go
go: downloading [github.com/AlecAivazis/survey/v2](http://github.com/AlecAivazis/survey/v2) v2.3.4
go: downloading [github.com/aws/aws-sdk-go](http://github.com/aws/aws-sdk-go) v1.44.19
go: downloading [github.com/sirupsen/logrus](http://github.com/sirupsen/logrus) v1.8.1
go: downloading [github.com/spf13/cobra](http://github.com/spf13/cobra) v1.4.0
go: downloading [golang.org/x/sys](http://golang.org/x/sys) v0.0.0-20220520151302-bc2c85ada10a
go: downloading [github.com/spf13/pflag](http://github.com/spf13/pflag) v1.0.5
go: downloading [golang.org/x/term](http://golang.org/x/term) v0.0.0-20220411215600-e5f449aeb171
go: downloading [github.com/mattn/go-colorable](http://github.com/mattn/go-colorable) v0.1.12
go: downloading [github.com/mattn/go-isatty](http://github.com/mattn/go-isatty) v0.0.14
go: downloading [github.com/jmespath/go-jmespath](http://github.com/jmespath/go-jmespath) v0.4.0

Issues

relates to #63
caused by golang/go#49219

Other changes

  • Update the devcontainer to 1.17-bullseye.

@ncatelli ncatelli requested a review from sendqueery May 20, 2022 21:31
@CLAassistant
Copy link

CLAassistant commented May 20, 2022

CLA assistant check
All committers have signed the CLA.

@zbintliff zbintliff self-requested a review May 24, 2022 13:45
@ncatelli ncatelli merged commit 2a7cbf2 into disneystreaming:develop May 24, 2022
@ncatelli ncatelli deleted the update-minimal-version-to-go-1.16 branch May 24, 2022 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants