Keep node_modules/ as they are required at runtime #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This solution is temporary until we have a better approach. The initial goal of the trimming of the .vsix was to reduce size of the package. The archive contains a lot of useless stuff (especially dev dependencies). Ideally, we would have one of the following: - improved pipeline that compiles, but then package with only `yarn install --production` - webpack that puts everything in a standalone file
|
for context:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This solution is temporary until we have a better approach. The
initial goal of the trimming of the .vsix was to reduce size of the
package. The archive contains a lot of useless stuff (especially
dev dependencies).
Ideally, we would have one of the following:
yarn install --production