Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update scala-xml dependency to version 2 #235

Closed
yanns opened this issue Jan 2, 2023 · 0 comments · Fixed by #237
Closed

Update scala-xml dependency to version 2 #235

yanns opened this issue Jan 2, 2023 · 0 comments · Fixed by #237

Comments

@yanns
Copy link
Contributor

yanns commented Jan 2, 2023

Problem statement

Dispatch is using scala-xml 1.2.0.

In the meantime, a version 2 was published. Other libraries have updated their dependency, leading to conflict when we want to update them:

[error] 	* org.scala-lang.modules:scala-xml_2.13:2.1.0 (early-semver) is selected over 1.2.0
[error] 	   +- XXXXX               (depends on 2.1.0)
[error] 	   +- org.dispatchhttp:dispatch-core_2.13:1.2.0          (depends on 1.2.0)

Proposed solution
Update scala-xml to version 2.1.0

I can open a PR if that helps.
I don't know if this project is still alive, and if a new version will be released with this change.
@yanns yanns mentioned this issue Jan 2, 2023
Open
yanns added a commit to yanns/reboot that referenced this issue Jan 2, 2023
@yanns
update scala-xml
d30bcc1 
fix dispatch#235
lift-json also depends on scala-xml 1.2.
lift-json is not maintained anymore.
I propose to remove the module.
@yanns yanns mentioned this issue Jan 2, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

update scala-xml yanns/reboot
1 participant
@yanns