Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close old client reference on configure #115

Closed
wants to merge 1 commit into from

Conversation

damienlevin
Copy link

I think the logic around configure should be changed. There is no reason to create a default instance until configure is called.

Anyhow, this should do the trick and not break the API.

@cb372
Copy link

cb372 commented Aug 25, 2015

+1 for the idea. I've been bitten by a resource leak caused by this as well. Currently any application that uses Dispatch and calls configure is not able to shutdown, because Dispatch leaks non-daemon Netty threads.

But your implementation doesn't compile because the method is missing its braces.

@fbascheper
Copy link
Contributor

@farmdawgnation AFAIK this PR was superseded by #118 , which has itself been superseded / merged by the upgrade to AHC 2.0.32.

@farmdawgnation
Copy link
Member

Acknowledged, closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants